gaborgsomogyi commented on a change in pull request #24590: [SPARK-27687][SS] 
Rename Kafka consumer cache capacity and document caching
URL: https://github.com/apache/spark/pull/24590#discussion_r283641327
 
 

 ##########
 File path: 
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/package.scala
 ##########
 @@ -33,8 +33,8 @@ package object kafka010 {   // scalastyle:ignore
       .createWithDefaultString("10m")
 
   private[kafka010] val CONSUMER_CACHE_CAPACITY =
 
 Review comment:
   Originally I've taken a look at the related migration guide 
(sql-migration-guide-upgrade) but there I haven't seen any parameter rename 
entry. Thought it's the way because of the following:
   * The parameter just deprecated and will work properly in 3.0 as well
   * The Spark config system will give a warning message which tells what is 
the new parameter
   
   If my thoughts are not correct please correct it and I'll comment on the 
migration doc.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to