beliefer commented on a change in pull request #24589: [MINOR][SS]Remove
duplicate 'add' in comment of `StructuredSessionization`.
URL: https://github.com/apache/spark/pull/24589#discussion_r283687056
##########
File path:
examples/src/main/scala/org/apache/spark/examples/sql/streaming/StructuredSessionization.scala
##########
@@ -70,15 +70,15 @@ object StructuredSessionization {
line.split(" ").map(word => Event(sessionId = word, timestamp))
}
- // Sessionize the events. Track number of events, start and end timestamps
of session, and
+ // Sessionize the events. Track number of events, start and end timestamps
of session,
// and report session updates.
val sessionUpdates = events
.groupByKey(event => event.sessionId)
.mapGroupsWithState[SessionInfo,
SessionUpdate](GroupStateTimeout.ProcessingTimeTimeout) {
case (sessionId: String, events: Iterator[Event], state:
GroupState[SessionInfo]) =>
- // If timed out, then remove session and send final update
+ // If timed out, remove session and send final update
Review comment:
> Hm, other two occurrences are fine.
>
> I'll just get this in - let's just keep the `and` typo fix only in this PR
>
> ```diff
> - // Sessionize the events. Track number of events, start and end
timestamps of session, and
> + // Sessionize the events. Track number of events, start and end
timestamps of session,
> ```
Is `Sessionize` a typo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
