hehuiyuan commented on issue #24219: [SPARK-27258][K8S]Deal with the k8s resource names that don't match their own regular expression URL: https://github.com/apache/spark/pull/24219#issuecomment-492189822 service name is a-z ，which is not a-z0-9 ---Original--- From: "Stavros Kontopoulos"<[email protected]> Date: Tue, May 14, 2019 17:06 PM To: "apache/spark"<[email protected]>; Cc: "Author"<[email protected]>;"hehuiyuan"<[email protected]>; Subject: Re: [apache/spark] [SPARK-27258][K8S]Deal with the k8s resource names that don't match their own regular expression (#24219) isValidName() method uses "a-z0-9?" which is in compliance with the k8s codebase for DNS-1123 labels and works for service names. Sanitize does not fix the dash issue as a first character I agree, btw this happened before because of truncation, but the sanitize method could be improved or re-use the logic for the executor pod names here. So its not just dash. I would refactor the code and use only one method to sanitize resourceNamePrefix because resourceNamePrefix can be used by the executor pods for the hostname thing anyway. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
