viirya commented on a change in pull request #24593: [SPARK-27692][SQL] Add new 
optimizer rule to evaluate the deterministic scala udf only once if all inputs 
are literals
URL: https://github.com/apache/spark/pull/24593#discussion_r283741849
 
 

 ##########
 File path: 
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
 ##########
 @@ -892,7 +893,7 @@ class AvroSuite extends QueryTest with SharedSQLContext 
with SQLTestUtils {
       assert(msg.contains("Cannot save interval data type into external 
storage."))
 
       msg = intercept[AnalysisException] {
-        spark.udf.register("testType", () => new IntervalData())
+        spark.udf.register("testType", udf(() => new 
IntervalData()).asNondeterministic())
 
 Review comment:
   For that, it's probably better to add comment here to explain it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to