dongjoon-hyun edited a comment on issue #24525: [SPARK-27633][SQL] Remove redundant aliases in NestedColumnAliasing URL: https://github.com/apache/spark/pull/24525#issuecomment-492309173 @viirya . Actually, I've been investigating this PR multiple times from the first day. But I couldn't make me sure about this approach. One big thing is `nestedFields.forall(f => f == n || child.find(_.semanticEquals(f)).isEmpty)`. `semanticEquals` is not a robust choice in `Struct` related operations. `semanticEquals` erases many information and frequently it bites us at some corner cases. I'm interested in this PR and testing this. Could you test this more seriously, too?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
