rdblue commented on a change in pull request #24570: [SPARK-24923][SQL]
Implement v2 CreateTableAsSelect
URL: https://github.com/apache/spark/pull/24570#discussion_r283900658
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceResolution.scala
##########
@@ -112,4 +129,41 @@ case class DataSourceResolution(conf: SQLConf) extends
Rule[LogicalPlan] with Ca
properties = properties,
comment = comment)
}
+
+ private def convertCTAS(
+ catalog: TableCatalog,
+ identifier: Identifier,
+ ctas: CreateTableAsSelectStatement): CreateTableAsSelect = {
+ if (ctas.options.contains("path") && ctas.location.isDefined) {
+ throw new AnalysisException(
+ "LOCATION and 'path' in OPTIONS are both used to indicate the custom
table path, " +
+ "you can only specify one of them.")
+ }
+
+ val options = ctas.options.filterKeys(_ != "path")
+
+ // convert the bucket spec and add it as a transform
+ val partitioning = ctas.partitioning ++ ctas.bucketSpec.map(_.asTransform)
+
+ // create table properties from TBLPROPERTIES and OPTIONS clauses
+ val properties = new mutable.HashMap[String, String]()
+ properties ++= ctas.properties
+ properties ++= options
+
+ // convert USING, LOCATION, and COMMENT clauses to table properties
+ properties += ("provider" -> ctas.provider)
+ ctas.comment.map(text => properties += ("comment" -> text))
Review comment:
I've added validations so that the properties and the clauses cannot both be
used. Setting "comment" and using a COMMENT clause will result in an
`AnalysisException`.
Passing these as well-known properties was included in the SPIP, but exactly
which properties are used should be documented. I'll open a documentation
issues and add it as a blocker for the 3.0 release.
If we want to define a prefix for the clauses that are passed as properties,
that sounds fine to me. What is a reasonable prefix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
