dongjoon-hyun commented on a change in pull request #23992: [SPARK-27074][SQL]
Hive 3.1 metastore support HiveClientImpl.runHive
URL: https://github.com/apache/spark/pull/23992#discussion_r283908058
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
##########
@@ -584,10 +586,11 @@ class VersionsSuite extends SparkFunSuite with Logging {
test(s"$version: sql read hive materialized view") {
// HIVE-14249 Since Hive 2.3.0, materialized view is supported.
- // But skip Hive 3.1 because of SPARK-27074.
- if (version == "2.3") {
+ if (version == "2.3" || version == "3.1") {
+ val disableRewrite = if (version == "2.3") "" else "DISABLE REWRITE"
Review comment:
Could you add a comment about the reason why we use `DISABLE REWRITE` in
`Hive 3.x`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
