gaborgsomogyi commented on a change in pull request #24627: [SPARK-27748][SS]
Kafka consumer/producer password/token redaction.
URL: https://github.com/apache/spark/pull/24627#discussion_r284754640
##########
File path:
external/kafka-0-10-token-provider/src/main/scala/org/apache/spark/kafka010/KafkaTokenUtil.scala
##########
@@ -268,8 +270,8 @@ private[spark] object KafkaTokenUtil extends Logging {
| serviceName="${clusterConf.kerberosServiceName}"
| username="$username"
| password="$password";
- """.stripMargin.replace("\n", "")
- logDebug(s"Scram JAAS params: ${params.replaceAll("password=\".*\"",
"password=\"[hidden]\"")}")
+ """.stripMargin.replace("\n", "").trim
Review comment:
This is unrelated fix. There were additional spaces at the end of the
generated string. This change removes it. Worth to mention the code works both
way but thought it's just ugly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
