gkumar7 commented on a change in pull request #17253: [SPARK-19916][SQL]
simplify bad file handling
URL: https://github.com/apache/spark/pull/17253#discussion_r284805556
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala
##########
@@ -90,16 +90,14 @@ trait FileFormat {
* @param options A set of string -> string configuration options.
* @return
*/
- def buildReader(
+ protected def buildReader(
sparkSession: SparkSession,
dataSchema: StructType,
partitionSchema: StructType,
requiredSchema: StructType,
filters: Seq[Filter],
options: Map[String, String],
hadoopConf: Configuration): PartitionedFile => Iterator[InternalRow] = {
- // TODO: Remove this default implementation when the other formats have
been ported
Review comment:
@cloud-fan I am wondering why the `buildReader` method is now marked as
`protected`? Maybe you can comment here:
https://issues.apache.org/jira/browse/SPARK-27751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
