viirya commented on a change in pull request #24626: [SPARK-27747][SQL] add a logical plan link in the physical plan URL: https://github.com/apache/spark/pull/24626#discussion_r284952775
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala ########## @@ -271,6 +271,8 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanT } object QueryPlan extends PredicateHelper { + val LOGICAL_PLAN_TAG_NAME = TreeNodeTagName("logical_plan") Review comment: Can we add some comment? For example, `After query plans go through SQL planner, the planner will attach the optimized logical plan to the generated physical plan under this tag name.` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org