squito commented on issue #24565: [SPARK-27665][Core] Split fetch shuffle 
blocks protocol from OpenBlocks
URL: https://github.com/apache/spark/pull/24565#issuecomment-493605920
 
 
   I think its very useful to have spark 3.0 be able to talk to a spark 2.4 
shuffle service.  The shuffle service can be harder to upgrade, as it effects 
all applications, while you could have a different spark version per 
application.  Especially across a version breaking compatibility, this makes it 
easier for users to upgrade incrementally.
   
   I was originally thinking that we'd extend the `RegisterExecutor` msg which 
the client sends to the shuffle server with a version: 
https://github.com/apache/spark/blob/master/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java#L143
   
   And I was hoping that only if that msg was not properly handled, then you'd 
auto-detect that you were talking to an old shuffle server.  So it would be the 
same number of rpcs when all the versions match, but an extra one if you're 
using new spark with old shuffle server, just across this initial boundary 
where we update this message type.  But that could actually be pretty slow I 
guess, so a config seems like a good option as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to