vanzin commented on issue #24499: [SPARK-27677][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation URL: https://github.com/apache/spark/pull/24499#issuecomment-493621811 I was kinda hoping you'd make the remove RPC a separate change... I need more time to look at that part, whereas the rest of the change was already ok for me. Two things I'll be looking at: whether the new RPC is only sent if the new feature it enabled (otherwise things will almost certainly break with older shuffle services), and whether it really needs to be an RPC (instead of just a one-way message with not reply, which is cheaper).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
