dongjoon-hyun commented on a change in pull request #24630: [SPARK-27754][K8S]
Introduce additional config (spark.kubernetes.driver.request.cores) for driver
request cores for spark on k8s
URL: https://github.com/apache/spark/pull/24630#discussion_r285326341
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStepSuite.scala
##########
@@ -117,6 +117,33 @@ class BasicDriverFeatureStepSuite extends SparkFunSuite {
assert(featureStep.getAdditionalPodSystemProperties() ===
expectedSparkConf)
}
+ test("Check driver pod respects kubernetes driver request cores") {
+ val sparkConf = new SparkConf()
+ .set(KUBERNETES_DRIVER_POD_NAME, "spark-driver-pod")
+ .set(CONTAINER_IMAGE, "spark-driver:latest")
+
+ val basePod = SparkPod.initialPod()
+ val requests1 = new
BasicDriverFeatureStep(KubernetesTestConf.createDriverConf(sparkConf))
+ .configurePod(basePod)
+ .container.getResources
+ .getRequests.asScala
+ assert(requests1("cpu").getAmount === "1")
Review comment:
That should be the following because we should not have a magic number in
the code.
```scala
- private val driverCpuCores = conf.get(DRIVER_CORES.key, "1")
+ private val driverCpuCores = conf.get(DRIVER_CORES)
```
```scala
val driverCpuQuantity = new QuantityBuilder(false)
- .withAmount(driverCpuCores)
+ .withAmount(driverCpuCores.toString)
```
Please fix like the above. And don't use magic numbers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
