dongjoon-hyun commented on a change in pull request #24631: [MINOR][CORE] Avoid
hardcoded configs
URL: https://github.com/apache/spark/pull/24631#discussion_r285328421
##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -595,7 +595,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging with Seria
// it will almost always cause ExecutorLostFailure. See SPARK-22754.
require(executorTimeoutThresholdMs > executorHeartbeatIntervalMs, "The
value of " +
s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be no less than
the value of " +
- s"spark.executor.heartbeatInterval=${executorHeartbeatIntervalMs}ms.")
+ s"${EXECUTOR_HEARTBEAT_INTERVAL.key}=${executorHeartbeatIntervalMs}ms.")
Review comment:
Could you update `SparkContextSuite.scala`, too?
```
- .set("spark.executor.heartbeatInterval", "1s")
+ .set(EXECUTOR_HEARTBEAT_INTERVAL.key, "1s")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
