HyukjinKwon commented on a change in pull request #24644: 
[SPARK-27402][INFRA][FOLLOW-UP][test-hadoop3.2][test-maven] Exclude 
'hive-thriftserver' in modules to test for hadoop3.2 for now
URL: https://github.com/apache/spark/pull/24644#discussion_r285417372
 
 

 ##########
 File path: dev/run-tests.py
 ##########
 @@ -122,9 +123,15 @@ def determine_modules_to_test(changed_modules):
     # If we need to run all of the tests, then we should short-circuit and 
return 'root'
     if modules.root in modules_to_test:
         return [modules.root]
-    return toposort_flatten(
+    changed_modules = toposort_flatten(
         {m: set(m.dependencies).intersection(modules_to_test) for m in 
modules_to_test}, sort=True)
 
+    # TODO: Skip hive-thriftserver module for hadoop-3.2. remove this once 
hadoop-3.2 support it
 
 Review comment:
   To be clear, this fix itself is a temp fix too in order to make the affected 
scope isolated and minimised. To fix it properly, we should maybe be able to 
fix it within `Module` at `modules.py`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to