cloud-fan commented on a change in pull request #24533: [SPARK-27637][Shuffle]
For nettyBlockTransferService, if IOException occurred while fetching data,
check whether relative executor is alive before retry
URL: https://github.com/apache/spark/pull/24533#discussion_r285438461
##########
File path:
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala
##########
@@ -112,8 +117,19 @@ private[spark] class NettyBlockTransferService(
val blockFetchStarter = new RetryingBlockFetcher.BlockFetchStarter {
override def createAndStart(blockIds: Array[String], listener:
BlockFetchingListener) {
val client = clientFactory.createClient(host, port)
- new OneForOneBlockFetcher(client, appId, execId, blockIds, listener,
- transportConf, tempFileManager).start()
+ try {
+ new OneForOneBlockFetcher(client, appId, execId, blockIds,
listener,
+ transportConf, tempFileManager).start()
+ } catch {
+ case e: IOException =>
+ assert(driverEndPointRef != null)
+ if (driverEndPointRef.askSync[Boolean](IsExecutorAlive(execId)))
{
Review comment:
If `askSync` fails, we should throw the original exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
