beliefer commented on issue #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource. URL: https://github.com/apache/spark/pull/24647#issuecomment-494215705 > > I'm not sure about the contract here, whether providers are required to be stateless. > > Since `providingClass` is state already having similar thing shouldn't be an issue. The gain is questionable though... > > AFAIK, Java reflection will result in significant performance issue. > > Since it's not called too many times the gain could be couple of milliseconds but I think this makes the code more simple. > > LGTM (pending tests). Yes, I agree. Many a little makes a mickle.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
