Github user ash211 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3841#discussion_r22482224
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1691,15 +1691,12 @@ private[spark] object Utils extends Logging {
/**
* Default maximum number of retries when binding to a port before
giving up.
*/
- val portMaxRetries: Int = {
+ lazy val portMaxRetries: Int = {
if (sys.props.contains("spark.testing")) {
// Set a higher number of retries for tests...
sys.props.get("spark.port.maxRetries").map(_.toInt).getOrElse(100)
} else {
- Option(SparkEnv.get)
- .flatMap(_.conf.getOption("spark.port.maxRetries"))
- .map(_.toInt)
- .getOrElse(16)
+ sys.props.get("spark.port.maxRetries").map(_.toInt).getOrElse(16)
--- End diff --
I'm worried that changing this to read from System properties rather than
the SparkEnv will break standalone mode here. Have you confirmed that
`spark.port.maxRetries` in standalone mode still works with this change?
In general we should prefer using SparkEnv over System properties because
they have all kind of gotchas. There's a reason we created SparkEnv in the
first place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
