dongjoon-hyun commented on a change in pull request #24221: [SPARK-27248][SQL]
`refreshTable` should recreate cache with same cache name and storage level
URL: https://github.com/apache/spark/pull/24221#discussion_r286157166
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala
##########
@@ -222,19 +222,6 @@ abstract class QueryTest extends PlanTest {
s"level $storageLevel, but it doesn't.")
}
- /**
- * Asserts that a given [[Dataset]] will be executed using the cache with
the given name
- */
- def assertCached(query: Dataset[_], cachedName: String): Unit = {
- val planWithCaching = query.queryExecution.withCachedData
- val matched = planWithCaching.collectFirst { case cached: InMemoryRelation
=>
- val cacheBuilder = cached.asInstanceOf[InMemoryRelation].cacheBuilder
- cachedName == cacheBuilder.tableName.get
- }.getOrElse(false)
-
- assert(matched, s"Expected query plan to hit cache $cachedName, but it
doesn't.")
- }
-
Review comment:
Thank you for removing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
