srowen commented on a change in pull request #24472: [SPARK-27578][SQL]Add
support for "interval '23:59:59' hour to second"
URL: https://github.com/apache/spark/pull/24472#discussion_r286669624
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
##########
@@ -56,6 +56,9 @@ private static String unitRegex(String unit) {
private static Pattern dayTimePattern =
Pattern.compile("^(?:['|\"])?([+|-])?(\\d+)
(\\d+):(\\d+):(\\d+)(\\.(\\d+))?(?:['|\"])?$");
+ private static Pattern hourTimePattern =
Review comment:
BTW all of these Patterns could be final.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
