cloud-fan commented on a change in pull request #24675: [SPARK-27803][SQL] fix
column pruning for python UDF
URL: https://github.com/apache/spark/pull/24675#discussion_r286738983
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
##########
@@ -226,22 +214,4 @@ object ExtractPythonUDFs extends Rule[LogicalPlan] with
PredicateHelper {
}
}
}
-
- // Split the original FilterExec to two FilterExecs. Only push down the
first few predicates
- // that are all deterministic.
- private def trySplitFilter(plan: LogicalPlan): LogicalPlan = {
Review comment:
quote from the PR description
> There are some hacks in the ExtractPythonUDFs rule, to duplicate the
column pruning and filter pushdown logic. However, it has some bugs as
demonstrated in the new test case(only column pruning is broken). This PR
removes the hacks and re-apply the column pruning and filter pushdown rules
explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
