beliefer commented on a change in pull request #24647: [SPARK-27776][SQL]Avoid
duplicate Java reflection in DataSource.
URL: https://github.com/apache/spark/pull/24647#discussion_r286753702
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##########
@@ -105,6 +105,8 @@ case class DataSource(
case _ => cls
}
}
+ private def providingInstance = providingClass.getConstructor().newInstance()
Review comment:
If we add a return type, only `Any` could use here. This method is modified
by private, so whether the return type can be omitted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
