cloud-fan commented on a change in pull request #24675:
[SPARK-27803][SQL][PYTHON] Fix column pruning for Python UDF
URL: https://github.com/apache/spark/pull/24675#discussion_r286841366
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/pythonLogicalOperators.scala
##########
@@ -38,3 +38,30 @@ case class FlatMapGroupsInPandas(
*/
override val producedAttributes = AttributeSet(output)
}
+
+trait BaseEvalPython extends UnaryNode {
Review comment:
This is a problem I want to address later. I think `producedAttributes`
makes no sense. It's only used to define `missingInput`, but we can overwrite
`reference` to do the same thing.
More specifically, if `reference` is wrong implemented, column pruning will
be broken. If `producedAttributes` is not implemented, nothing seriously will
happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
