cloud-fan commented on a change in pull request #24653: [SPARK-27783][SQL] Add
customizable hint error handler
URL: https://github.com/apache/spark/pull/24653#discussion_r286868607
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
##########
@@ -130,10 +130,7 @@ object ResolveHints {
relationNames.foreach(relationNameSet.add)
val applied = applyJoinStrategyHint(h.child, relationNameSet, h.name)
- relationNameSet.foreach { n =>
- logWarning(s"Count not find relation '$n' for join strategy hint "
+
- s"'${h.name}${relationNames.mkString("(", ", ", ")")}'.")
- }
+ hintErrorHandler.handleHintRelationsNotFound(h.name, h.parameters,
relationNameSet.toSet)
Review comment:
This is specific to join hints right? Maybe we should rename
`handleHintRelationsNotFound` to something join specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
