wangyum commented on a change in pull request #24486: [SPARK-27592][SQL] Set
the bucketed data source table SerDe correctly
URL: https://github.com/apache/spark/pull/24486#discussion_r286969496
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
##########
@@ -359,11 +359,12 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
(None, message)
// our bucketing is un-compatible with hive(different hash function)
- case _ if table.bucketSpec.nonEmpty =>
+ case Some(serde) if table.bucketSpec.nonEmpty =>
val message =
s"Persisting bucketed data source table $qualifiedTableName into " +
- "Hive metastore in Spark SQL specific format, which is NOT
compatible with Hive. "
- (None, message)
+ "Hive metastore in Spark SQL specific format, which is NOT
compatible with Hive. " +
+ "But Hive can read it as not bucketed table."
+ (Some(newHiveCompatibleMetastoreTable(serde)), message)
Review comment:
Not necessary:
https://github.com/apache/spark/blob/fee695d0cf211e4119c7df7a984708628dc9368a/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L1009-L1023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
