cloud-fan commented on a change in pull request #24682: [SPARK-27762][SQL]
[FOLLOWUP] Add behavior change for Avro writer in migration guide
URL: https://github.com/apache/spark/pull/24682#discussion_r287355479
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala
##########
@@ -234,15 +236,20 @@ class AvroSerializer(rootCatalystType: DataType,
rootAvroType: Schema, nullable:
}
private def resolveNullableType(avroType: Schema, nullable: Boolean): Schema
= {
- if (nullable && avroType.getType != NULL) {
Review comment:
one idea to keep the diff small
```
if (nullable && avroType == Type.Union) {
...
} else {
if (nullable) logWarining ...
avroType
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
