abellina commented on a change in pull request #24541: [SPARK-27646] [SQL] 
[WIP] Required refactoring for bytecode analysis
URL: https://github.com/apache/spark/pull/24541#discussion_r287424350
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala
 ##########
 @@ -27,6 +26,7 @@ import org.apache.xbean.asm7.Opcodes._
 
 import org.apache.spark.{SparkEnv, SparkException}
 import org.apache.spark.internal.Logging
+import org.apache.spark.util.Utils.getSerializedLambda
 
 Review comment:
   since we are already in `org.apacke.spark.util`, could we just call 
`Utils.getSerializedLambda` from the `clean`? We seem to refer to other static 
functions in `Utils` using the classname.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to