mgaido91 commented on a change in pull request #24553: [SPARK-27604][SQL] 
Enhance constant propagation
URL: https://github.com/apache/spark/pull/24553#discussion_r287478943
 
 

 ##########
 File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ConstantPropagationSuite.scala
 ##########
 @@ -37,10 +38,12 @@ class ConstantPropagationSuite extends PlanTest {
         Batch("ConstantPropagation", FixedPoint(10),
           ConstantPropagation,
           ConstantFolding,
-          BooleanSimplification) :: Nil
+          BooleanSimplification,
+          SimplifyBinaryComparison,
 
 Review comment:
   why do we need to add these 2?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to