jkbradley commented on a change in pull request #24705: [SPARK-22340][PYTHON] 
Save localProperties in thread.local
URL: https://github.com/apache/spark/pull/24705#discussion_r287539153
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
 ##########
 @@ -159,7 +159,12 @@ private[spark] object PythonRDD extends Logging {
    * @return 2-tuple (as a Java array) with the port number of a local socket 
which serves the
    *         data collected from this job, and the secret for authentication.
    */
-  def collectAndServe[T](rdd: RDD[T]): Array[Any] = {
+  def collectAndServe[T](
 
 Review comment:
   I'll let @ueshin judge, but my guess is that, even though this is a 
"private" API, we'll want to add a new collectAndServe with the 2 arguments, 
leaving the old one in case 3rd-party libraries use the private API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to