peter-toth commented on a change in pull request #24553: [SPARK-27604][SQL]
Enhance constant propagation
URL: https://github.com/apache/spark/pull/24553#discussion_r287490602
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
##########
@@ -197,7 +197,7 @@ class FileSourceStrategySuite extends QueryTest with
SharedSQLContext with Predi
"when checking partition values")
}
// Only the filters that do not contain the partition column should be
pushed down
- checkDataFilters(Set(IsNotNull("c1"), EqualTo("c1", 1)))
+ checkDataFilters(Set(EqualTo("c1", 1)))
Review comment:
The old `ConstantPropagation` replaced an attribute to a constant in
`EqualTo` and `EqualNullSafe` expressions only. The new one doesn't make a such
limitation.
Since we know that `c1` equals to 1 in this example I think we can omit this
trivial `IsNotNull` filter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
