srowen commented on a change in pull request #24647: [SPARK-27776][SQL]Avoid
duplicate Java reflection in DataSource.
URL: https://github.com/apache/spark/pull/24647#discussion_r287578923
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##########
@@ -105,6 +105,9 @@ case class DataSource(
case _ => cls
}
}
+
+ private def providingInstance(): Any =
providingClass.getConstructor().newInstance()
Review comment:
It's definitely at least an `AnyRef`. Can you write `private def [T <:
AnyRef] providingInstance(): T`? You can even tighten the bound with a cast,
as we know the supertype of what's being returned.
However I don't think it's worth it. You can use AnyRef or omit the type
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
