dongjoon-hyun commented on a change in pull request #24472:
[SPARK-27578][SQL]Add support for "interval '23:59:59' hour to second"
URL: https://github.com/apache/spark/pull/24472#discussion_r287579706
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -653,6 +653,19 @@ class ExpressionParserSuite extends PlanTest {
checkIntervals(s"'$value' day to second", result)
}
+ // Day-Time intervals.
+ val hourTimeValues = Seq(
+ "11:22:33.123456789",
+ "11:22:33.123456789",
Review comment:
Why do we have two same test coverage? It seems that this is copied from
line 654~650 blindly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
