zsxwing commented on a change in pull request #24683: [SPARK-20547][REPL]Throw
RemoteClassLoadedError for transient errors in ExecutorClassLoader
URL: https://github.com/apache/spark/pull/24683#discussion_r287605945
##########
File path: repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala
##########
@@ -115,23 +127,31 @@ class ExecutorClassLoader(
}
}
+ // See
org.apache.spark.network.server.TransportRequestHandler.processStreamRequest.
+ private val STREAM_NOT_FOUND_REGEX = s"Stream '.*' was not found.".r.pattern
Review comment:
`nonexistent class and transient errors should cause different errors`
doesn't mock `TransportRequestHandler`. It would fail if someone changed the
error message.
> I think nobody will ever realize the problem if the message in
`TransportRequestHandler` changed (only on cluster).
Good point. I added a comment near the error message so that people can
notice the error message string is used here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
