JoshRosen commented on a change in pull request #24709: [SPARK-27841][SQL]
Improve UTF8String to/fromString()/numBytesForFirstByte() performance
URL: https://github.com/apache/spark/pull/24709#discussion_r287611672
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
##########
@@ -1217,6 +1264,20 @@ public boolean toByte(IntWrapper intWrapper) {
@Override
public String toString() {
+ byte[] bytes = getBytes();
+ // Optimization for ASCII characters: use deprecated string API which
+ // skips charset encoder and simply casts each byte into a char.
+ if (isAscii(bytes)) {
+ return new String(bytes, 0);
+ } else {
+ return new String(bytes, StandardCharsets.UTF_8);
+ }
+ }
+
+ /**
+ * Pre-SPARK-27841 version of toString(), retained for benchmarking purposes.
+ */
+ public String toStringSlow() {
Review comment:
I don't think so: the benchmarks that I added are in a different package
(because it's hard to depend on our benchmarks package from the `unsafe`
package), so this needs to be public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
