dongjoon-hyun commented on a change in pull request #24652: [SPARK-27782][SQL]
Use '#' to mark expression id embedded in the name field of SubqueryExec
operator
URL: https://github.com/apache/spark/pull/24652#discussion_r287611689
##########
File path:
sql/core/src/test/resources/sql-tests/inputs/subquery/scalar-subquery/scalar-subquery-predicate.sql
##########
@@ -279,3 +279,4 @@ HAVING max(t1b) <= (SELECT max(t2b)
FROM t2
WHERE t2c = t1c
GROUP BY t2c);
+
Review comment:
Ur, please revert this, too. And we need to update PR description.
Especially, the following. We had better keep narrow context in this PR.
```
This is to help SQLQueryTestSuite anonymize these expression ids.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
