skonto edited a comment on issue #24613: [SPARK-27549][SS] Add support for committing kafka offsets per batch for supporting external tooling URL: https://github.com/apache/spark/pull/24613#issuecomment-496030795 > In general, if there is a negative opinion, the PR is not considered as a mergeable PR. @dongjoon-hyun Do you also think that the code base is too large so adding a few lines of code brings more fuss than value? This PR affects the `external` part of the code base and not really the core or any other basic part as people have done with the Flink case. I would also like to hear your opinion if possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
