HyukjinKwon commented on a change in pull request #24335: [SPARK-27425][SQL] Add count_if functions URL: https://github.com/apache/spark/pull/24335#discussion_r287773618
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala ########## @@ -0,0 +1,73 @@ +/* Review comment: Not necessary but in that way we can just rewrite and reuse the expressions (take a look for them). `Every`, `Any`, `Some` are similar instances like this case but they were rewritten as `Max` and `Min` . Let's follow that way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
