srowen commented on a change in pull request #24717: [SPARK-27847][ML] One-Pass
MultilabelMetrics & MulticlassMetrics
URL: https://github.com/apache/spark/pull/24717#discussion_r287792619
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/MultilabelMetrics.scala
##########
@@ -38,76 +40,62 @@ class MultilabelMetrics @Since("1.2.0")
(predictionAndLabels: RDD[(Array[Double]
(r.getSeq[Double](0).toArray, r.getSeq[Double](1).toArray)
})
- private lazy val numDocs: Long = predictionAndLabels.count()
+ /**
+ * Use MultilabelSummarizer to calculate all summary statistics of
predictions
+ * and labels on one pass.
+ */
+ private lazy val summary: MultilabelSummary = {
+ predictionAndLabels
+ .treeAggregate(new MultilabelSummarizer)(
+ (summary, sample) => summary.add(sample._1, sample._2),
Review comment:
Can `sample` be written as `(label, prediction)` for clarity? I forget
whether Scala allows nested tuples here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
