Ngone51 commented on a change in pull request #24569: [SPARK-23191][CORE] Warn
rather than terminate when duplicate worker register happens
URL: https://github.com/apache/spark/pull/24569#discussion_r287832950
##########
File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
##########
@@ -250,13 +250,13 @@ private[deploy] class Master(
if (state == RecoveryState.STANDBY) {
workerRef.send(MasterInStandby)
} else if (idToWorker.contains(id)) {
- workerRef.send(RegisterWorkerFailed("Duplicate worker ID"))
+ workerRef.send(RegisteredWorker(self, masterWebUiUrl, masterAddress,
true))
Review comment:
Yes, we have to. Each time worker is trying to connect to masters, it sets
`registered=false` and only set to `true` when it receives master's
response(`RegisteredWorker`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
