Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/3916#issuecomment-68948473
  
    A few pre-emptive comments:
    
    - I understand this change is a little large. I'd recommend looking at 
separate commits if you feel overwhelmed. But I don't think breaking it down 
would make sense; github is not friendly to "incremental" patches so it would 
slow down review a lot.
    
    - I tested the following combinations:
      - the unit tests
      - spark-submit, spark-shell and pyspark on Linux (local, yarn 
client/cluster, standalone)
      - spark-submit, spark-shell and pyspark on Windows (local)
    
    The yarn and standalone tests used our internal test harness, which was 
unmodified, so this shows the new scripts are backwards compatible with the old 
ones (to the extent our tests exercise them).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to