dongjoon-hyun edited a comment on issue #24472: [SPARK-27578][SQL] Support INTERVAL ... HOUR TO SECOND syntax URL: https://github.com/apache/spark/pull/24472#issuecomment-496358371 Hi, @gatorsmile and @cloud-fan . Could you give us some directional advice, please? - First, this PR wants to support `INTERVAL ... HOUR TO SECOND` like `INTERVAL ... DAY TO SECOND` like Presto/Terradata. It looks reasonable to me, too. - Second, originally, this PR added a new pattern and new function (which is similar to the existing one). To avoid maintaining two similar functions, I recommended to extend the existing pattern and handling `DAY` and `HOUR` with the same function. To sum up, we will support 2~4 additionally. 1. SELECT INTERVAL '0 23:59:59.155' DAY TO SECOND (Current Spark) 1. SELECT INTERVAL '23:59:59.155' HOUR TO SECOND 1. SELECT INTERVAL '23:59:59.155' DAY TO SECOND 1. SELECT INTERVAL '1 23:59:59.155' HOUR TO SECOND If you think these are okay, I want to merge this PR. How do you think about this?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
