felixcheung commented on a change in pull request #24732: [SPARK-27868][core]
Better default value and documentation for socket server backlog.
URL: https://github.com/apache/spark/pull/24732#discussion_r288388516
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
##########
@@ -108,8 +108,8 @@ public int numConnectionsPerPeer() {
return conf.getInt(SPARK_NETWORK_IO_NUMCONNECTIONSPERPEER_KEY, 1);
}
- /** Requested maximum length of the queue of incoming connections. Default
-1 for no backlog. */
- public int backLog() { return conf.getInt(SPARK_NETWORK_IO_BACKLOG_KEY, -1);
}
+ /** Requested maximum length of the queue of incoming connections. Default
is 64. */
+ public int backLog() { return conf.getInt(SPARK_NETWORK_IO_BACKLOG_KEY, 64);
}
Review comment:
what's the different between setting to -1 or to 64 as a default? does this
change any existing behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
