rednaxelafx commented on a change in pull request #24735: [SPARK-27871][SQL]
LambdaVariable should use per-query unique IDs instead of globally unique IDs
URL: https://github.com/apache/spark/pull/24735#discussion_r288706970
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -575,15 +575,43 @@ case class WrapOption(child: Expression, optType:
DataType)
}
}
+object LambdaVariable {
+ private val curId = new java.util.concurrent.atomic.AtomicLong()
+
+ // Returns the codegen-ed `LambdaVariable` and add it to mutable states, so
that it can be
Review comment:
I don't like this part. It might make codegen a bit easier to write but
you're making unnecessary hoisting of local variables to Java object fields.
Doesn't sound like a good idea to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
