rdblue commented on a change in pull request #24686: [SPARK-27813][SQL]
DataSourceV2: Add DropTable logical operation
URL: https://github.com/apache/spark/pull/24686#discussion_r288798833
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -438,4 +441,63 @@ class PlanResolutionSuite extends AnalysisTest {
s"got ${other.getClass.getName}: $sql")
}
}
+
+ test("drop table") {
+ val tableName1 = "db.tab"
+ val tableIdent1 = TableIdentifier("tab", Option("db"))
+ val tableName2 = "tab"
+ val tableIdent2 = TableIdentifier("tab", None)
+
+ parseResolveCompare(s"DROP TABLE $tableName1",
+ DropTableCommand(tableIdent1, ifExists = false, isView = false, purge =
false))
+ parseResolveCompare(s"DROP TABLE IF EXISTS $tableName1",
+ DropTableCommand(tableIdent1, ifExists = true, isView = false, purge =
false))
+ parseResolveCompare(s"DROP TABLE $tableName2",
+ DropTableCommand(tableIdent2, ifExists = false, isView = false, purge =
false))
+ parseResolveCompare(s"DROP TABLE IF EXISTS $tableName2",
+ DropTableCommand(tableIdent2, ifExists = true, isView = false, purge =
false))
+ parseResolveCompare(s"DROP TABLE $tableName2 PURGE",
+ DropTableCommand(tableIdent2, ifExists = false, isView = false, purge =
true))
+ parseResolveCompare(s"DROP TABLE IF EXISTS $tableName2 PURGE",
+ DropTableCommand(tableIdent2, ifExists = true, isView = false, purge =
true))
+ }
+
+ test("drop table v2") {
+ val tableName1 = "testcat.db.tab"
+ val tableIdent1 = Identifier.of(Array("db"), "tab")
+ val tableName2 = "testcat.tab"
+ val tableIdent2 = Identifier.of(Array.empty, "tab")
+
+ parseResolveCompare(s"DROP TABLE $tableName1",
+ DropTable(testCat, tableIdent1, ifExists = false))
+ parseResolveCompare(s"DROP TABLE IF EXISTS $tableName1",
+ DropTable(testCat, tableIdent1, ifExists = true))
+ parseResolveCompare(s"DROP TABLE $tableName2",
+ DropTable(testCat, tableIdent2, ifExists = false))
+ parseResolveCompare(s"DROP TABLE IF EXISTS $tableName2",
+ DropTable(testCat, tableIdent2, ifExists = true))
+ }
+
+ test("drop view") {
+ val viewName1 = "db.view"
+ val viewIdent1 = TableIdentifier("view", Option("db"))
+ val viewName2 = "view"
+ val viewIdent2 = TableIdentifier("view")
+
+ parseResolveCompare(s"DROP VIEW $viewName1",
+ DropTableCommand(viewIdent1, ifExists = false, isView = true, purge =
false))
+ parseResolveCompare(s"DROP VIEW IF EXISTS $viewName1",
+ DropTableCommand(viewIdent1, ifExists = true, isView = true, purge =
false))
+ parseResolveCompare(s"DROP VIEW $viewName2",
+ DropTableCommand(viewIdent2, ifExists = false, isView = true, purge =
false))
+ parseResolveCompare(s"DROP VIEW IF EXISTS $viewName2",
+ DropTableCommand(viewIdent2, ifExists = true, isView = true, purge =
false))
+ }
+
+ test("drop view v2") {
+ assertAnalysisError(
+ parseAndResolve("DROP VIEW testcat.db.view"),
+ Seq("unresolved operator 'DropViewStatement"),
Review comment:
We could implement a better rule in checkAnalysis for these, while there are
not v2 implementations. Do you think this should be done in this PR, or could
it be in a follow-up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
