cloud-fan commented on a change in pull request #24686: [SPARK-27813][SQL]
DataSourceV2: Add DropTable logical operation
URL: https://github.com/apache/spark/pull/24686#discussion_r288817502
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -139,8 +139,8 @@ statement
DROP (IF EXISTS)? partitionSpec (',' partitionSpec)*
#dropTablePartitions
| ALTER TABLE tableIdentifier partitionSpec? SET locationSpec
#setTableLocation
| ALTER TABLE tableIdentifier RECOVER PARTITIONS
#recoverPartitions
- | DROP TABLE (IF EXISTS)? tableIdentifier PURGE?
#dropTable
- | DROP VIEW (IF EXISTS)? tableIdentifier
#dropTable
+ | DROP TABLE (IF EXISTS)? multipartIdentifier PURGE?
#dropTable
+ | DROP VIEW (IF EXISTS)? multipartIdentifier
#dropView
Review comment:
do we have view support in DS v2? This is surprising to me, as I thought we
may treat table/view differently in DS v2. Personally I think it's a bad idea
that hive unifies table and view, it's weird to see the `sqlText` field in Hive
`Table` class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
