Ngone51 commented on a change in pull request #24497: [SPARK-27630][CORE]Stage
retry causes totalRunningTasks calculation to be negative
URL: https://github.com/apache/spark/pull/24497#discussion_r288841722
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -756,10 +757,10 @@ private[spark] class ExecutorAllocationManager(
val taskId = taskEnd.taskInfo.taskId
val taskIndex = taskEnd.taskInfo.index
val stageId = taskEnd.stageId
+ val stageAttemptId = taskEnd.stageAttemptId
+ val stageAttempt = (stageId, stageAttemptId)
Review comment:
IIRC, we receive only one `SparkListenerStageCompleted` event for multiple
stage attempts. And, it's possible that `SparkListenerTaskEnd` comes from
previous stage attempt after we've received `SparkListenerStageCompleted`. In
that case, we need to clean up related structures for those stage attempts in
`onTaskEnd`(if this is a final finished task within corresponding stage
attempt) as we already do in `onStageCompleted`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
