dongjoon-hyun commented on a change in pull request #24739:
[SPARK-27875][CORE][SQL][ML][K8S] Wrap all PrintWriter with
Utils.tryWithResource
URL: https://github.com/apache/spark/pull/24739#discussion_r288845646
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
##########
@@ -749,10 +749,10 @@ class SparkSubmitSuite
withTempDir { tmpDir =>
// Test jars and files
val f1 = File.createTempFile("test-submit-jars-files", "", tmpDir)
- val writer1 = new PrintWriter(f1)
- writer1.println("spark.jars " + jars)
- writer1.println("spark.files " + files)
- writer1.close()
+ Utils.tryWithResource(new PrintWriter(f1)) { writer1 =>
Review comment:
The current one reduces the diff, but let's use `writer` instead of
`writer1`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
