jzhuge edited a comment on issue #24741: [SPARK-27322][SQL] DataSourceV2: Select from multiple catalogs URL: https://github.com/apache/spark/pull/24741#issuecomment-497212984 There are 2 major design points in this PR: 1. Create TableIdentifierLike interface to ease the migration from legacy TableIdentifier to CatalogTableIdentifier 2. Resolve multipart table identifier to CatalogTableIdentifier/TableIdentifier in `AstBuilder`. Don't quite like this choice but it seems to minimize changes in this PR comparing to alternatives that I will list below. I discovered these sore spots so far in the transition from TableIdentifier to CatalogTableIdentifier: - CTE relation - View text - Hints Alternatives to resolving multipart table identifier in AstBuilder - Parser.parsePlan - Analyzer. We can switch to this choice after taking care of the sore spots.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
