MaxGekk commented on a change in pull request #24742: [SPARK-27881][SQL]
Support CAST (... FORMAT <pattern>) expression
URL: https://github.com/apache/spark/pull/24742#discussion_r289048855
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -238,10 +245,50 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
private lazy val dateFormatter = DateFormatter()
private lazy val timestampFormatter =
TimestampFormatter.getFractionFormatter(zoneId)
+ private lazy val customDateFormatter: DateFormatter = format.map { f =>
Review comment:
Is it possible to still use `dateFormatter` and `timestampFormatter` in
`Cast` instead of custom formatters. For example, I would define them:
```Scala
private lazy val dateFormatter =
format.map(DateFormatter(_)).getOrElse(DateFormatter())
private lazy val timestampFormatter = format
.map(TimestampFormatter(_, zoneId))
.getOrElse(TimestampFormatter.getFractionFormatter(zoneId))
```
Are there any downsides of that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
