dongjoon-hyun commented on a change in pull request #24327: [SPARK-27418][SQL]
Migrate Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#discussion_r289259062
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -238,7 +240,8 @@ case class AlterTableAddColumnsCommand(
// TextFileFormat only default to one column "value"
// Hive type is already considered as hive serde table, so the logic
will not
// come in here.
- case _: JsonFileFormat | _: CSVDataSourceV2 | _: ParquetFileFormat |
_: OrcDataSourceV2 =>
+ case _: JsonFileFormat | _: CSVFileFormat | _: ParquetFileFormat =>
Review comment:
Could you make this another small PR since this is Parquet migration PR?
Also, it would be great if the PR has a test coverage for this missing part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]